Add validation scenario tests - #2503
Merged
rogancarr merged 12 commits intoFeb 13, 2019
Merged
Conversation
added 8 commits
February 6, 2019 14:57
Codecov Report
@@ Coverage Diff @@
## master #2503 +/- ##
==========================================
+ Coverage 71.25% 71.25% +<.01%
==========================================
Files 798 797 -1
Lines 141252 141270 +18
Branches 16112 16112
==========================================
+ Hits 100643 100658 +15
- Misses 36145 36151 +6
+ Partials 4464 4461 -3
|
glebuk
self-requested a review
February 12, 2019 18:34
glebuk
reviewed
Feb 12, 2019
| var preprocessedValidData = preprocessor.Transform(validData); | ||
|
|
||
| // Train the model with a validation set | ||
| var trainedModel = mlContext.Regression.Trainers.FastTree(numTrees: 2) |
Contributor
There was a problem hiding this comment.
trainedModel [](start = 16, length = 12)
add early stopping criteria in the options so that the validation set is actually useful.
Such as https://docs.microsoft.com/en-us/dotnet/api/microsoft.ml.trainers.fasttree.boostedtreeargs.earlystoppingrule?view=ml-dotnet #Closed
glebuk
reviewed
Feb 12, 2019
| // Combine the model | ||
| var model = preprocessor.Append(trainedModel); | ||
|
|
||
| // Score the data sets |
Contributor
There was a problem hiding this comment.
sets [](start = 30, length = 4)
periods at the end of comments throughout. #Closed
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test for training with a validation set.
Fixes #2499